Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][offload] Replace usage of shaded class in OffsetsCache #22683

Merged
merged 1 commit into from
May 9, 2024
Merged

[improve][offload] Replace usage of shaded class in OffsetsCache #22683

merged 1 commit into from
May 9, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 9, 2024

Motivation

When cherry-picking #22679 to branch-3.0, the build failed.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project tiered-storage-jcloud: Compilation failure
[ERROR] /Users/lari/workspace-pulsar/pulsar-branch-3.0/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java:[23,53] package io.grpc.netty.shaded.io.netty.util.concurrent does not exist

I had made a mistake and used a shaded class in OffsetsCache

Modifications

  • replace with Guava's ThreadFactoryBuilder since Guava is already available in the tiered storage dependencies

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone May 9, 2024
@lhotari lhotari requested a review from Technoboy- May 9, 2024 07:49
@lhotari lhotari self-assigned this May 9, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 9, 2024
@lhotari lhotari changed the title [improve][offlload] Replace usage of shaded class in OffsetsCache [improve][offload] Replace usage of shaded class in OffsetsCache May 9, 2024
lhotari added a commit that referenced this pull request May 9, 2024
@lhotari
[improve][offload] Replace usage of shaded class in OffsetsCache (#22683
395a886 
)
@lhotari lhotari mentioned this pull request May 9, 2024
Merged
4 tasks
@lhotari lhotari merged commit 03a4995 into apache:master May 9, 2024
53 of 56 checks passed
lhotari added a commit that referenced this pull request May 9, 2024
@lhotari
[improve][offload] Replace usage of shaded class in OffsetsCache (#22683
f88a413 
)

(cherry picked from commit 03a4995)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
@lhotari @nikhil-ctds
[improve][offload] Replace usage of shaded class in OffsetsCache (apa…
89cab16 
…che#22683)

(cherry picked from commit 395a886)
@lhotari lhotari mentioned this pull request May 13, 2024
Closed
coderzc pushed a commit that referenced this pull request May 14, 2024
@lhotari @coderzc
[improve][offload] Replace usage of shaded class in OffsetsCache (#22683
32be893 
)

(cherry picked from commit 03a4995)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
@lhotari @srinath-ctds
[improve][offload] Replace usage of shaded class in OffsetsCache (apa…
2a96f95 
…che#22683)

(cherry picked from commit 395a886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dao-jun dao-jun dao-jun approved these changes

@nodece nodece nodece approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

Assignees

@lhotari lhotari

Labels
area/tieredstorage cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.11.5 release/3.0.5 release/3.2.3 release/3.3.0
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lhotari @Technoboy- @codelipenghui @nodece @dao-jun @coderzc