Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] [broker] disable loadBalancerDirectMemoryResourceWeight by default #22821

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[fix] [broker] disable loadBalancerDirectMemoryResourceWeight by default #22821

merged 1 commit into from
Jun 4, 2024

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Jun 3, 2024 •
edited
Loading

Motivation

PR #21168 has disable loadBalancerDirectMemoryResourceWeight by default. But there is still some places not changed.

Modifications

Change the default value of all places to 0.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 3, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @lhotari @Demogorgon314 @heesung-sn @BewareMyPower

@thetumbled
Copy link
Member Author

/pulsarbot rerun-failure-checks

@BewareMyPower BewareMyPower added this to the 3.4.0 milestone Jun 4, 2024
@BewareMyPower BewareMyPower merged commit 02fd1ee into apache:master Jun 4, 2024
52 of 53 checks passed
Technoboy- pushed a commit that referenced this pull request Jun 6, 2024
@thetumbled @Technoboy-
[fix] [broker] disable loadBalancerDirectMemoryResourceWeight by defa…
8dc5f2e 
…ult (#22821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heesung-sn heesung-sn heesung-sn approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

Assignees

@thetumbled thetumbled

Labels
cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs release/3.3.1
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thetumbled @Demogorgon314 @heesung-sn @Technoboy- @BewareMyPower