[fix] [client] Fix resource leak in Pulsar Client since HttpLookupService doesn't get closed #22858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
4 tasks
There was a problem hiding this comment.
I don't think it's actual a memory leak. This PR only clears the map after closeAsync is called. However, I could hardly think of a case that a PulsarClient is still used after closeAsync. When the PulsarClientImpl object is GC'ed, this map will be GC'ed as well.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Show resolved
Hide resolved
lhotari
changed the title
@BewareMyPower I agree. I renamed "memory leak" to "resource leak" in the title. /cc @poorbarcode Threads get leaked since the underlying HttpClient of the HttpLookupService doesn't get closed. |
lhotari
changed the title
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
poorbarcode
requested review from
BewareMyPower
and removed request for
BewareMyPower
BewareMyPower
approved these changes
Jun 18, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2024
…vice doesn't get closed (apache#22858) (cherry picked from commit bc3dc77) (cherry picked from commit e9264a9)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…vice doesn't get closed (apache#22858) (cherry picked from commit bc3dc77) (cherry picked from commit e9264a9)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…vice doesn't get closed (apache#22858) (cherry picked from commit bc3dc77) (cherry picked from commit e9264a9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…vice doesn't get closed (apache#22858) (cherry picked from commit bc3dc77) (cherry picked from commit e9264a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#21356 added a resource map
urlLookupMapinPulsarClientImpl.class, but did not release the lookup services when closing PulsarClient.Modifications
Release
urlLookupMapwhen closing PulsarClientDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x