[fix][cli] Fix Pulsar standalone shutdown - bkCluster wasn't closed #22868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
nodece,
BewareMyPower,
tisonkun and
coderzc
nodece
approved these changes
Jun 7, 2024
lhotari
force-pushed
the
lh-fix-pulsar-standalone-shutdown
branch
from
f75bce2
to
534fde9
Compare
lhotari
force-pushed
the
lh-fix-pulsar-standalone-shutdown
branch
from
534fde9
to
fb41d8d
Compare
merlimat
approved these changes
Jun 7, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 17, 2024
…pache#22868) (cherry picked from commit c5cc25e) (cherry picked from commit ebb4282)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…pache#22868) (cherry picked from commit c5cc25e) (cherry picked from commit ebb4282)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…pache#22868) (cherry picked from commit c5cc25e) (cherry picked from commit ebb4282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar standalone doesn't shutdown cleanly. bkCluster isn't closed when the shutdown hook executes. This problem has been present since 2.11.0 (#15478).
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete