[improve] [pip] PIP-358: let resource weight work for OverloadShedder, LeastLongTermMessageRate, ModularLoadManagerImpl.

[thetumbled]

Implementation PR: #22888

Motivation

Initially, we introduce loadBalancerCPUResourceWeight, loadBalancerBandwidthInResourceWeight, loadBalancerBandwidthOutResourceWeight, loadBalancerMemoryResourceWeight, loadBalancerDirectMemoryResourceWeight in ThresholdShedder to control the resource weight for different resources when calculating the load of the broker.

Then we let it work for LeastResourceUsageWithWeight for better bundle placement policy.

But #19559 and #21168 have point out that the actual load of the broker is not related to the memory usage and direct memory usage, thus we have changed the default value of loadBalancerMemoryResourceWeight, loadBalancerDirectMemoryResourceWeight to 0.0.

There are still some places where memory usage and direct memory usage are used to calculate the load of the broker, such as OverloadShedder, LeastLongTermMessageRate, ModularLoadManagerImpl. We should let the resource weight work for these places so that we can set the resource weight to 0.0 to avoid the impact of memory usage and direct memory usage on the load of the broker.

Modifications

• Let resource weight work for OverloadShedder, LeastLongTermMessageRate, ModularLoadManagerImpl.

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[thetumbled]

PTAL, thanks. @Demogorgon314 @heesung-sn @codelipenghui @BewareMyPower @Technoboy-

[heesung-sn]

Could you clarify what's the detail update for OverloadShedder, LeastLongTermMessageRate, ModularLoadManagerImp by this PIP?

[thetumbled]

Could you clarify what's the detail update for OverloadShedder, LeastLongTermMessageRate, ModularLoadManagerImp by this PIP?

Updated, PTAL, thanks.