[improve][broker] Use RoaringBitmap in tracking individual acks to reduce memory usage #23006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/enhancement
lhotari
requested review from
merlimat,
dao-jun,
Demogorgon314,
shibd and
mattisonchao
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23006 +/- ##
============================================
- Coverage 73.57% 73.45% -0.12%
- Complexity 32624 33301 +677
============================================
Files 1877 1912 +35
Lines 139502 143195 +3693
Branches 15299 15590 +291
============================================
+ Hits 102638 105190 +2552
- Misses 28908 29996 +1088
- Partials 7956 8009 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dao-jun
approved these changes
Jul 5, 2024
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 10, 2024
…duce memory usage (apache#23006) (cherry picked from commit ed39c4d) (cherry picked from commit 278d679)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
…duce memory usage (apache#23006) (cherry picked from commit ed39c4d) (cherry picked from commit 278d679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22866
Motivation
There has been a previous attempt to address #22866 in #22908 which caused regressions and this PR was reverted by #22968.
After that, PR #22966 made ConcurrentOpenLongPairRangeSet thread safe and renamed the class to OpenLongPairRangeSet. The PR makes changes to the class to properly and consistently use the existing ReadWriteLock for all accesses.
This PR contains the next step to use the RoaringBitSet class that @dao-jun has contributed to RoaringBitmap 1.1.0. The usage of RoaringBitmap reduces memory usage compared to java.util.BitSet and presumable addresses issue #22866.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete