Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) #23064

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Jul 22, 2024

Motivation

  • Found a bug that the ownership monitor tries to clean owned bundles from inactive source brokers

Modifications

  • Fix the bug not to clean owned bundles from inactive source brokers
  • Cleaned/refactored override ownership code
  • Skip unloading LB internal topics. Instead, close those topics when shutting down the broker.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: heesung-sn#75

Copy link

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@heesung-sn heesung-sn self-assigned this Jul 22, 2024
@heesung-sn heesung-sn added this to the 3.4.0 milestone Jul 22, 2024
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 22, 2024
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 22, 2024
@dragosvictor
Copy link
Contributor

Should this not be cherry-picked to 3.1 too?

@heesung-sn
Copy link
Contributor Author

heesung-sn commented Jul 23, 2024

Should this not be cherry-picked to 3.1 too?

Sure. I can push it there too.

@heesung-sn heesung-sn closed this Jul 24, 2024
@heesung-sn heesung-sn reopened this Jul 24, 2024
@heesung-sn heesung-sn merged commit 55e468e into apache:master Jul 24, 2024
50 of 51 checks passed
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jul 25, 2024
…brokers (ExtensibleLoadManagerImpl only) (apache#23064)

(cherry picked from commit 55e468e)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jul 26, 2024
…brokers (ExtensibleLoadManagerImpl only) (apache#23064)

(cherry picked from commit 55e468e)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jul 26, 2024
…brokers (ExtensibleLoadManagerImpl only) (apache#23064)

(cherry picked from commit 55e468e)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jul 27, 2024
…brokers (ExtensibleLoadManagerImpl only) (apache#23064)

(cherry picked from commit 55e468e)
heesung-sn added a commit that referenced this pull request Jul 27, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (#23064) (#23084)
heesung-sn added a commit that referenced this pull request Jul 27, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (#23064) (#23085)
heesung-sn added a commit that referenced this pull request Jul 27, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (#23064) (#23082)
heesung-sn added a commit that referenced this pull request Jul 27, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (#23064) (#23077)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 29, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (apache#23064) (apache#23077)

(cherry picked from commit 55d32f2)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 30, 2024
…tive source brokers (ExtensibleLoadManagerImpl only) (apache#23064) (apache#23077)

(cherry picked from commit 55d32f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants