[fix][test] Fix flaky UnloadSubscriptionTest.testMultiConsumer #23243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23243 +/- ##
============================================
+ Coverage 73.57% 74.56% +0.99%
- Complexity 32624 34274 +1650
============================================
Files 1877 1926 +49
Lines 139502 144989 +5487
Branches 15299 15850 +551
============================================
+ Hits 102638 108111 +5473
+ Misses 28908 28616 -292
- Partials 7956 8262 +306
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhotari
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit a678e97)
lhotari
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit a678e97)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 10, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #19508 (comment)
This problem still exists. The root cause is that
BatchIndexAcknowledgmentis not enabled.Modifications
enable batch index acknowledgment
Documentation
docdoc-requireddoc-not-neededdoc-complete