Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #148] Throwables.propagate is deprecated for making runtime exception more verbose #160

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Abhijeetmishr
Copy link
Contributor

…n more verbose

What is the purpose of the change

#148
The Throwables.propagate() method has been deprecated in Guava version 21.0 because it can lead to confusion and make it difficult to track down the root cause of an exception.

Code Changes from :-
Throwables.propagate(e)

code changes to:-
Throwables.throwIfUnchecked(e);
throw new RuntimeException(e);

@Abhijeetmishr Abhijeetmishr changed the title [#148] Throwables.propagate in deprecated for making runtime exception more verbose [#148] Throwables.propagate is deprecated for making runtime exception more verbose Apr 18, 2023
@Abhijeetmishr
Copy link
Contributor Author

@Oliverwqcwrw request review on this.

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oliverwqcwrw Oliverwqcwrw changed the title [#148] Throwables.propagate is deprecated for making runtime exception more verbose [ISSUE #148] Throwables.propagate is deprecated for making runtime exception more verbose Apr 18, 2023
@Oliverwqcwrw Oliverwqcwrw merged commit 6456630 into apache:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants