-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#35] Use LitePullConsumer
model instead of default pull consumer
#46
Conversation
there are some problems about this code, like home to Use defaultlitPullConsumer to get offset and perform offset self-management |
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @yiduwangkai contribution. I have left the comments for this pull request. Did you test the changes? In addtion, please resolve the conflicts.
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
============================================
+ Coverage 28.50% 28.62% +0.11%
Complexity 164 164
============================================
Files 62 62
Lines 2529 2536 +7
Branches 269 269
============================================
+ Hits 721 726 +5
- Misses 1741 1743 +2
Partials 67 67 ☔ View full report in Codecov by Sentry. |
Thanks for @yiduwangkai updates. Could you please resolve the conflicts and squash the commits? |
7b39d52
to
f1861be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @yiduwangkai updates. I left some comments for this update. PTAL.
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java
Show resolved
Hide resolved
src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java
Outdated
Show resolved
Hide resolved
LitePullConsumer
model instead of default pull consumer
src/main/java/org/apache/rocketmq/flink/source/enumerator/RocketMQSourceEnumerator.java
Show resolved
Hide resolved
src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java
Outdated
Show resolved
Hide resolved
Thanks, @yiduwangkai for your contributions. I left some comments, but I'm not familiar with rocketmq-flink, so please @SteNicholas help have a look. |
f1861be
to
3f5fbe4
Compare
Since not all broker versions support lite pull, we need to clarify it in our doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
close #35
Use
DefaultLitePullConsumer
model instead of default pull consumer.Tips
Thank you very much for contributing to Apache rocketmq-flink.
What is the purpose of the pull request
*solve some code about using defaultPullConsumer api
Brief change log
(for example:)
*Modify
RocketMQConfig.java
RocketMQSourceFunction.java
RocketMQSourceEnumerator.java
RocketMQPartitionSplitReader.java
RocketMQSourceTest.java