-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect comment of method[TransactionalMessageBridge#addRemoveTagInTransactionOp()] may mislead others. #3687
Labels
Milestone
Comments
XiaoyiPeng
added a commit
to XiaoyiPeng/rocketmq
that referenced
this issue
Dec 31, 2021
XiaoyiPeng
changed the title
Incorrect method[TransactionalMessageBridge#addRemoveTagInTransactionOp()] description may mislead others.
Incorrect comment of method[TransactionalMessageBridge#addRemoveTagInTransactionOp()] may mislead others.
Jan 1, 2022
francisoliverlee
added a commit
that referenced
this issue
Jan 6, 2022
…ransaction_msg [ISSUE #3687] Fix wrong method comment about transaction message.
devfat
pushed a commit
to devfat/rocketmq
that referenced
this issue
Mar 3, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this issue
Aug 12, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this issue
Aug 12, 2022
…bout_transaction_msg [ISSUE apache#3687] Fix wrong method comment about transaction message.
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this issue
Sep 10, 2024
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this issue
Sep 10, 2024
…bout_transaction_msg [ISSUE apache#3687] Fix wrong method comment about transaction message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BUG REPORT
Please describe the issue you observed:
When I read the following code about transaction messages, I noticed a problem with the method comments in class
TransactionalMessageBridge
.But in fact:
The param
messageExt
of the method ishalf message
instead ofOp message
.The param
messageQueue
of the method ishalf message queue
instead ofOp message queue
.To prove my point, I debugged the code,as shown below:
Please tell us about your environment:
Windows 10.
The text was updated successfully, but these errors were encountered: