-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate code in TopicPublishInfo #6398
Comments
IMO, It's a good idea, welcome your PR :-) |
Hi there! I'm interested in working on this issue. It aligns with my skills. Could you please assign this issue to me, or guide me on how to get started? Thanks! |
@Oliverwqcwrw I would like to work on this in case it is not picked up yet. |
I would like to work on this, Could you please assign it to me? |
i see this hasn't been assigned yet, can I work on this? |
@Oliverwqcwrw Kindly to ask if there is somebody working for this issue? lf not, I'm glad to undertake it. |
Thank you very much for your attention to the community, I noticed that the latest code has changed, please take a look at the latest code to check whether the problem still exists :) |
Is it possible for this issue to be closed in the near future? If not, I'll try to follow up on it. |
The code block below in the selectOneMessageQueue method is identical to another overloaded method (2nd code block).
rocketmq/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java
Lines 74 to 76 in 7d67484
rocketmq/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java
Lines 85 to 90 in 7d67484
IMO, it can be rewritten like this.
If it's acceptable, I will submit a pull request.
The text was updated successfully, but these errors were encountered: