Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#6398] Remove duplicate code in TopicPublishInfo #6412

Closed
wants to merge 1 commit into from

Conversation

zyx333
Copy link
Contributor

@zyx333 zyx333 commented Mar 20, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6398

Brief changelog

Remove duplicate code in TopicPublishInfo

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql_analysis.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.13%. Comparing base (f1e02e8) to head (fd5f033).
Report is 623 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6412      +/-   ##
=============================================
+ Coverage      43.05%   43.13%   +0.08%     
- Complexity      8911     8943      +32     
=============================================
  Files           1105     1105              
  Lines          77970    78048      +78     
  Branches       10146    10158      +12     
=============================================
+ Hits           33570    33669      +99     
+ Misses         40190    40163      -27     
- Partials        4210     4216       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byeongjaeSon
Copy link

LGTM

Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Apr 20, 2024
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate code in TopicPublishInfo
3 participants