Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl list will add many AccessValidator in proxy #6612

Closed
leizhiyuan opened this issue Apr 18, 2023 · 1 comment · Fixed by #6615
Closed

acl list will add many AccessValidator in proxy #6612

leizhiyuan opened this issue Apr 18, 2023 · 1 comment · Fixed by #6615

Comments

@leizhiyuan
Copy link
Contributor

leizhiyuan commented Apr 18, 2023 •
edited
Loading

if open the acl config in proxy,

rocketmq/proxy/src/main/java/org/apache/rocketmq/proxy/remoting/pipeline/AuthenticationPipeline.java

Line 41 in b3868ab

accessValidatorList.add(new PlainAccessValidator());

@joeCarf
Copy link
Contributor

joeCarf commented Apr 18, 2023

please assign this to me :)

@joeCarf joeCarf mentioned this issue Apr 18, 2023
Merged
6 tasks
yuz10 pushed a commit that referenced this issue Apr 18, 2023
@joeCarf
[ISSUE #6612] Prevent redundant validator in accessValidatorList (#6615)
f9f7147 
* change map -> lambda

* f

* fix unit test

* remove getTopicConfig function

* Update MultiDispatchTest.java

* Update CompactionStore.java

* update

* update test

* update test

* Update BatchConsumeMessageTest.java

* Update BrokerController.java

* Update BrokerController.java

* check

* Update BrokerController.java

* Update BatchConsumeMessageTest.java

* prevent redundant validator

* fix

* ci

* ci

* Update AuthenticationPipeline.java

* Update RemotingProtocolServer.java

* Update AuthenticationPipeline.java

* Update RemotingProtocolServer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6612] Prevent redundant validator in accessValidatorList
2 participants
@leizhiyuan @joeCarf