Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConsumerLagCalculator#processAllGroup retry topic NPE #6627

Closed
drpmma opened this issue Apr 21, 2023 · 0 comments · Fixed by #6628
Closed

Fix ConsumerLagCalculator#processAllGroup retry topic NPE #6627

drpmma opened this issue Apr 21, 2023 · 0 comments · Fixed by #6628

Comments

@drpmma
Copy link
Contributor

drpmma commented Apr 21, 2023

There may cause a NPE when retryTopic is not exist
see

rocketmq/broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java

Lines 180 to 184 in 1986c6b

int retryTopicPerm = retryTopicConfig.getPerm() & brokerConfig.getBrokerPermission();
if (PermName.isReadable(retryTopicPerm) || PermName.isWriteable(retryTopicPerm)) {
consumer.accept(new ProcessGroupInfo(group, topic, true, retryTopic));
} else {
consumer.accept(new ProcessGroupInfo(group, topic, true, null));

drpmma added a commit to drpmma/rocketmq that referenced this issue Apr 21, 2023
@drpmma
[ISSUE apache#6627] Fix ConsumerLagCalculator#processAllGroup retry t…
a1a4dbf 
…opic NPE
@drpmma drpmma mentioned this issue Apr 21, 2023
Merged
lizhimins pushed a commit that referenced this issue Apr 21, 2023
@drpmma
[ISSUE #6627] Fix ConsumerLagCalculator#processAllGroup retry topic N…
af6a95f 
…PE (#6628)
lizhimins added a commit to lizhimins/rocketmq that referenced this issue Apr 23, 2023
@lizhimins
[ISSUE apache#6627] Fix ConsumerLagCalculator#getAvailableMsgCount NP…
df699ff 
…E if group or topic is null
lizhimins added a commit to lizhimins/rocketmq that referenced this issue Apr 24, 2023
@lizhimins
[ISSUE apache#6627] Fix ConsumerLagCalculator NPE if group or topic i…
e6a5f86 
…s null
lizhimins added a commit that referenced this issue Apr 25, 2023
@lizhimins
[ISSUE #6627] Fix ConsumerLagCalculator NPE if group or topic is null (…
652f5bb 
…#6632)

Co-authored-by: 斜阳 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6627] Fix ConsumerLagCalculator#processAllGroup retry topic NPE drpmma/rocketmq
1 participant
@drpmma