Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize DefaultMQPushConsumer construction method #8227

Closed
1 task done
yx9o opened this issue May 30, 2024 · 1 comment · Fixed by #8228
Closed
1 task done

[Enhancement] Optimize DefaultMQPushConsumer construction method #8227

yx9o opened this issue May 30, 2024 · 1 comment · Fixed by #8228
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement

Comments

@yx9o
Copy link
Contributor

yx9o commented May 30, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

I found a duplicate structure in the constructor.
image

Motivation

To reduce code duplication and improve code reusability.

Describe the Solution You'd Like

We can let one constructor call another constructor, and finally perform the actual assignment operation only in one constructor.

Describe Alternatives You've Considered

In each constructor, directly call the most complete constructor.

Additional Context

No response
yx9o added a commit to yx9o/rocketmq that referenced this issue May 30, 2024
@yx9o
[ISSUE apache#8227] Repeated merging in the constructor
edddf75
@yx9o yx9o mentioned this issue May 30, 2024
Merged
yuz10 pushed a commit that referenced this issue Jun 13, 2024
@yx9o
[ISSUE #8227] Optimize DefaultMQPushConsumer construction method (#8228)
017b753
@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Aug 22, 2024
@ShannonDing
Copy link
Member

link #8262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8227] Repeated merging in the constructor yx9o/rocketmq
2 participants
@yx9o @ShannonDing