Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] getMaxReconsumeTimes calculation error in concurrent consumption mode #8490

Closed
3 tasks done
yx9o opened this issue Aug 4, 2024 · 0 comments · Fixed by #8491
Closed
3 tasks done

[Bug] getMaxReconsumeTimes calculation error in concurrent consumption mode #8490

yx9o opened this issue Aug 4, 2024 · 0 comments · Fixed by #8491

Comments

@yx9o
Copy link
Contributor

yx9o commented Aug 4, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Mac

RocketMQ version

develop

JDK Version

jdk8

Describe the Bug

getMaxReconsumeTimes is calculated incorrectly in concurrent consumption mode and cannot be directly compared with -1. It should be compared with the actual value represented by -1 in concurrent consumption mode.
企业微信截图_5cd261b7-1d01-40e3-9045-e1020cc2f234

Steps to Reproduce

Running this IT test will fail. org.apache.rocketmq.test.retry.PopConsumerRetryIT#testNormalMessageUseMessageVersionV2.
image
image

What Did You Expect to See?

Running this IT test will succeed. org.apache.rocketmq.test.retry.PopConsumerRetryIT#testNormalMessageUseMessageVersionV2.

What Did You See Instead?

Running this IT test will fail. org.apache.rocketmq.test.retry.PopConsumerRetryIT#testNormalMessageUseMessageVersionV2.

Additional Context

No response

yx9o added a commit to yx9o/rocketmq that referenced this issue Aug 4, 2024
cserwen pushed a commit that referenced this issue Aug 5, 2024
…t consumption mode (#8491)

* [ISSUE #8490] Fix getMaxReconsumeTimes calculation error in concurrent consumption mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant