Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6145] modify Collections.sort usage #6146

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[ISSUE #6145] modify Collections.sort usage #6146

merged 2 commits into from
Feb 28, 2023

Conversation

hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6145

Brief changelog

modify Collections.sort usage

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI first. Thx.

@hardyfish hardyfish closed this Feb 22, 2023
@hardyfish hardyfish reopened this Feb 22, 2023
@hardyfish
Copy link
Contributor Author

Please fix the CI first. Thx.

I reexecuted it.

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/statictopic/TopicQueueMappingUtils.java:25:8: Unused import - java.util.Comparator. [UnusedImports]
Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:20:8: Unused import - java.util.Collections. [UnusedImports]
Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:21:8: Unused import - java.util.Comparator. [UnusedImports]
Audit done.

@hardyfish
Copy link
Contributor Author

Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/statictopic/TopicQueueMappingUtils.java:25:8: Unused import - java.util.Comparator. [UnusedImports] Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:20:8: Unused import - java.util.Collections. [UnusedImports] Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:21:8: Unused import - java.util.Comparator. [UnusedImports] Audit done.

okay, I'll handle that.

@RongtongJin RongtongJin merged commit 33371e5 into apache:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify Collections.sort usage
4 participants