Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #6203] Allow to publish delay message with arbitrary timestamp #6204

Merged
merged 2 commits into from
Mar 28, 2023
Merged

[ISSUE #6203] Allow to publish delay message with arbitrary timestamp #6204

merged 2 commits into from
Mar 28, 2023

Conversation

aaron-ai
Copy link
Member

Fixes #6203

@aaron-ai aaron-ai requested a review from xdkxlk February 28, 2023 02:28
@xdkxlk xdkxlk mentioned this pull request Feb 28, 2023
Closed
fuyou001
fuyou001 previously approved these changes Feb 28, 2023
View reviewed changes
@aaron-ai aaron-ai changed the title Allow to publish delay message with arbitrary timestamp [ISSUE #6203] Allow to publish delay message with arbitrary timestamp Feb 28, 2023
drpmma
drpmma previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mxsm
mxsm reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI not pass! Please check it

hzh0425
hzh0425 previously approved these changes Mar 1, 2023
View reviewed changes
@aaron-ai aaron-ai dismissed stale reviews from hzh0425, drpmma, and fuyou001 via 7da5251 March 28, 2023 06:18
@codecov-commenter
Copy link

Codecov Report

Merging #6204 (7da5251) into develop (77cb5ce) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6204      +/-   ##
=============================================
- Coverage      43.19%   43.19%   -0.01%     
+ Complexity      9017     9016       -1     
=============================================
  Files           1107     1107              
  Lines          78257    78257              
  Branches       10202    10202              
=============================================
- Hits           33802    33801       -1     
- Misses         40223    40227       +4     
+ Partials        4232     4229       -3
Impacted Files Coverage Δ
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 54.20% <100.00%> (-0.86%) ⬇️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xdkxlk
xdkxlk approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 59b49de into apache:develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsm mxsm mxsm left review comments

@xdkxlk xdkxlk xdkxlk approved these changes

@hzh0425 hzh0425 hzh0425 left review comments

@drpmma drpmma drpmma left review comments

@fuyou001 fuyou001 fuyou001 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to publish delay message with arbitrary timestamp
7 participants
@aaron-ai @codecov-commenter @fuyou001 @xdkxlk @mxsm @drpmma @hzh0425