[ISSUE #6513] fix(proxy): enhance ProxyContext #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
drpmma
requested changes
Apr 3, 2023
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/interceptor/AuthenticationInterceptor.java
Outdated
Show resolved
Hide resolved
xdkxlk
reviewed
Apr 6, 2023
proxy/src/main/java/org/apache/rocketmq/proxy/common/ProxyContext.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/org/apache/rocketmq/proxy/common/ContextVariable.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/activity/ClientManagerActivity.java
Show resolved
Hide resolved
xdkxlk
previously approved these changes
Apr 7, 2023
drpmma
requested changes
Apr 7, 2023
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java
Show resolved
Hide resolved
|
Please rebase the develop branch to resolve the CI issue, please refer to #6560 for more details. |
Signed-off-by: lyx <[email protected]>
Signed-off-by: lyx2000 <[email protected]>
Signed-off-by: lyx <[email protected]>
Signed-off-by: lyx <[email protected]>
lyx2000
force-pushed
the
feature/improve-proxyContext
branch
from
cc30b96
to
a551ebc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6522 +/- ##
=============================================
+ Coverage 43.07% 43.09% +0.01%
- Complexity 8992 8998 +6
=============================================
Files 1107 1107
Lines 78260 78295 +35
Branches 10201 10202 +1
=============================================
+ Hits 33713 33743 +30
- Misses 40318 40329 +11
+ Partials 4229 4223 -6
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhouxinyu
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6513
Brief changelog
add the relevant client information into the channel attr when client heartbeat to ProxyContext