-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6525]Make ConsumeQueueInterface extends from FileQueueLifeCycle #6534
Conversation
|
You have successfully added a new CodeQL configuration |
Codecov Report
@@ Coverage Diff @@
## develop #6534 +/- ##
=============================================
- Coverage 43.07% 43.06% -0.01%
+ Complexity 8992 8988 -4
=============================================
Files 1107 1107
Lines 78260 78260
Branches 10201 10201
=============================================
- Hits 33713 33706 -7
- Misses 40318 40325 +7
Partials 4229 4229
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@ni-ze okay got it. |
赞,我之前也想改这里来着! |
@lizhimins didn't get you ? |
hey @Oliverwqcwrw @ni-ze I can see some build failures, how do I resolve them any hint/help is appreciated ? |
@Abhijeetmishr |
|
There is another force convert in ConsumeQueueStore. |
@Abhijeetmishr Merge develop into your branch, and then submit pr again, checks will be success. |
@ni-ze Merge develop into your branch :- you mean to say that take pull from develop branch to my branch and push along with changes? |
@@ -79,7 +79,7 @@ public void setTopicConfigTable(ConcurrentMap<String, TopicConfig> topicConfigTa | |||
} | |||
|
|||
private FileQueueLifeCycle getLifeCycle(String topic, int queueId) { | |||
return (FileQueueLifeCycle) findOrCreateConsumeQueue(topic, queueId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another force convert in recoverConcurrently method of this class.
Make sure set the target branch to
develop
What is the purpose of the change
close #6525
we are typecasting here
but interface is not extending FileQueueLifeCycle.
So it will throw typecast error.