[ISSUE #6537] Fix bug MessageStoreConfig.haListenPort item config not…

[hhy50]

[fix] fix6537

After the configuration file is loaded, it was overwritten by the subsequent setHaListenPort

After removing this line of code, the configuration takes effect

[RongtongJin]

If the user has not configured it, could the default port for HA be set to nettyServerConfig.getListenPort() + 1 ?

[hhy50]

haListenPort default value is nettyServerConfig.getListenPort()'default value +1

[hhy50]

nettyServerConfig.listenPort default value is 10911

[caigy]

IMO this PR will break the compatibility, that is, the default value of haLitenPort is listenPort + 1. Users setting listenPort but not setting haLitenPort explicitly will find haLitenPort changes after updating to new version.

The more appropriate way may be:

• if haLitenPort is set explicitly, use the value set by user;
• if haLitenPort is not set, assign listenPort + 1 to it.

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/codeql_analysis.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[hhy50]

@RongtongJin I see that you have approved it, but ci test not pass, what do i need todo

[TheR1sing3un]

@RongtongJin I see that you have approved it, but ci test not pass, what do i need todo

You can trigger CI again by command: git commit --allow-empty -m "rerun" && git push

[codecov-commenter]

Codecov Report

Merging #6538 (7847646) into develop (af6a95f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6538      +/-   ##
=============================================
+ Coverage      43.07%   43.09%   +0.01%     
- Complexity      8990     8991       +1     
=============================================
  Files           1107     1107              
  Lines          78289    78291       +2     
  Branches       10203    10204       +1     
=============================================
+ Hits           33725    33740      +15     
+ Misses         40341    40324      -17     
- Partials        4223     4227       +4     

Impacted Files	Coverage Δ
...java/org/apache/rocketmq/broker/BrokerStartup.java	6.36% <0.00%> (-0.09%)	⬇️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[caigy]

IMO this PR will break the compatibility, that is, the default value of haLitenPort is listenPort + 1. Users setting listenPort but not setting haLitenPort explicitly will find haLitenPort changes after updating to new version.

The more appropriate way may be:

• if haLitenPort is set explicitly, use the value set by user;
• if haLitenPort is not set, assign listenPort + 1 to it.

[hhy50]

@caigy Thank you for your suggestion. I have resubmitted it

[caigy]

LGTM