-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RIP-63] Queue Selection Strategy Optimization #6568
Merged
Merged
Changes from 44 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a4f01fc
add latency files.
GenerousMan 96f90ca
modify the logic of selectOneMessageQueue
GenerousMan 63cbbac
faultStrategy modify.
GenerousMan 4bfe568
modify updateFaultItems.
GenerousMan da61ed2
add remoting switch
GenerousMan 8ddf4a2
start the detector
GenerousMan 19bb1d9
modify the config
GenerousMan e22b40b
modify the config
GenerousMan f0a4b73
prepare the proxy modification
GenerousMan ab08b2d
proxy's latencyTolerance done, then we need filters.
GenerousMan fde2dea
fix style.
GenerousMan 9ee6dab
test the proxy
GenerousMan d4216c1
finish proxy's faultStrategy.
GenerousMan 542369e
remove useless files.
GenerousMan 19bd944
checkstyle.
GenerousMan ae362da
add exceptionally logic.
GenerousMan 472ecc9
fix unit test's bug.
GenerousMan 4c01506
add a unit test.
GenerousMan 83f55e4
remove useless methods.
GenerousMan 0d83652
Merge branch 'develop' into queueFilter
GenerousMan 98516ac
Merge branch 'develop' of https://github.com/apache/rocketmq into que…
GenerousMan ded23c3
refactor
GenerousMan cf9fe17
remove useless import and methods.
GenerousMan 3841201
optimized the reset method.
GenerousMan ffe22e5
still using getMaxOffset() to detect brokers' status.
GenerousMan ee385d8
make BrokerFilter static, to avoid the find-bug's notification.
GenerousMan b3ef18f
add some comment to describe the switch 'sendLatencyEnable'.
GenerousMan f1f52f9
Put TopicRouteService into queueSelector, instead of passing into sel…
GenerousMan 27dd55f
fix checkstyle.
GenerousMan 2610988
fix the test case 'testSendNormalMessageQueueSelector'.
GenerousMan 8535cd9
optimize the queueSelector's init function.
GenerousMan 0732b2c
Merge branch 'develop' into queueFilter_new
GenerousMan 1957f69
solve conflict.
GenerousMan 27ce8f6
Merge branch 'develop' into queueFilter_new
GenerousMan 02c560d
polish.
GenerousMan 481ba50
Merge branch 'develop' into queueFilter_new
GenerousMan 774f486
fix conflict.
GenerousMan e9334eb
polish
GenerousMan 6b39ab5
polish
GenerousMan 3a43bde
polish
GenerousMan 70efe49
Merge branch 'develop' into queueFilter_new
GenerousMan 196a642
fix wrong modification.
GenerousMan 74d6405
Merge branch 'develop' into queueFilter_new
GenerousMan 90320fa
make the switch false default.
GenerousMan ce56323
use whenComplete instead of exceptionally.
GenerousMan 1ec969b
modify the requested changes.
GenerousMan 0924aae
checkstyle.
GenerousMan 57279e8
fix test bug.
GenerousMan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,14 @@ public int incrementAndGet() { | |
return index & POSITIVE_MASK; | ||
} | ||
|
||
public void reset() { | ||
int index = Math.abs(random.nextInt(Integer.MAX_VALUE)); | ||
if (index < 0) { | ||
index = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the code redundant |
||
} | ||
this.threadLocalIndex.set(index); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "ThreadLocalIndex{" + | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be prudent to incorporate a warning concerning order message within the document,may be order message is disturbed