Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6591] Fix Starting nameserver and broker failed because the default java path in Darwin contained Spaces #6592

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

fix #6591

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

… the default java command in Darwin contained Spaces
@Oliverwqcwrw Oliverwqcwrw changed the title [ISSUE #6591] Fix Starting nameserver and broker failed because the default java command in Darwin contained Spaces [ISSUE #6591] Fix Starting nameserver and broker failed because the default java path in Darwin contained Spaces Apr 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6592 (f530809) into develop (d34a28b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6592   +/-   ##
==========================================
  Coverage      43.08%   43.09%           
- Complexity      8996     8999    +3     
==========================================
  Files           1107     1107           
  Lines          78295    78295           
  Branches       10202    10202           
==========================================
+ Hits           33736    33739    +3     
+ Misses         40333    40331    -2     
+ Partials        4226     4225    -1     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drpmma
Copy link
Contributor

drpmma commented Apr 18, 2023

LGTM

@drpmma drpmma merged commit ca006ca into apache:develop Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting nameserver and broker failed because the default java path in Darwin contained Spaces
4 participants