Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6610] Fix the issue broker startup failed when version upgrade from 5.1.0 to latest develop because compactionThreadNum is 0 #6611

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6610

Brief changelog

Fix the issue broker startup failed when version upgrade from 5.1.0 to latest develop because compactionThreadNum is 0

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…o latest develop because compactionThreadNum is 0
@codecov-commenter
Copy link

Codecov Report

Merging #6611 (8b63fd9) into develop (ca006ca) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6611      +/-   ##
=============================================
+ Coverage      43.07%   43.09%   +0.01%     
- Complexity      8988     8993       +5     
=============================================
  Files           1107     1107              
  Lines          78287    78287              
  Branches       10202    10202              
=============================================
+ Hits           33726    33740      +14     
+ Misses         40335    40318      -17     
- Partials        4226     4229       +3     
Impacted Files Coverage Δ
.../org/apache/rocketmq/store/kv/CompactionStore.java 31.73% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@zhouxinyu zhouxinyu merged commit 073da6b into apache:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker startup failed when version upgrade from 5.1.0 to latest develop
6 participants