Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6629] Rewrite the issue/PR template of RocketMQ #6645

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

aaron-ai
Copy link
Member

Fixes #6629

@aaron-ai aaron-ai marked this pull request as draft April 25, 2023 06:44
@aaron-ai aaron-ai changed the title Rewrite the issue template of RocketMQ [ISSUE #6629] Rewrite the issue template of RocketMQ Apr 25, 2023
@aaron-ai aaron-ai force-pushed the issue_template branch 8 times, most recently from 71b8d9b to fc497d5 Compare April 25, 2023 07:39
@aaron-ai aaron-ai changed the title [ISSUE #6629] Rewrite the issue template of RocketMQ [ISSUE #6629] Rewrite the issue/PR template of RocketMQ Apr 25, 2023
@aaron-ai aaron-ai force-pushed the issue_template branch 6 times, most recently from bd67302 to 93bb08d Compare April 25, 2023 08:55
@aaron-ai aaron-ai marked this pull request as ready for review April 25, 2023 08:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #6645 (6a406a4) into develop (652f5bb) will increase coverage by 43.08%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             develop    #6645       +/-   ##
==============================================
+ Coverage           0   43.08%   +43.08%     
- Complexity         0     8990     +8990     
==============================================
  Files              0     1107     +1107     
  Lines              0    78307    +78307     
  Branches           0    10208    +10208     
==============================================
+ Hits               0    33742    +33742     
- Misses             0    40343    +40343     
- Partials           0     4222     +4222     

see 1107 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add templates like 'enhancement' in addition to 'bug_report' and 'feature_request'? For example, for typo fixes or small optimizations that may not be big enough to be considered a feature request.

@aaron-ai
Copy link
Member Author

Do we need to add templates like 'enhancement' in addition to 'bug_report' and 'feature_request'? For example, for typo fixes or small optimizations that may not be big enough to be considered a feature request.

Nice idea! I will add a new template about it.

@aaron-ai aaron-ai marked this pull request as draft April 26, 2023 01:40
@aaron-ai aaron-ai force-pushed the issue_template branch 2 times, most recently from 791b328 to 52e983d Compare April 26, 2023 01:57
@aaron-ai aaron-ai marked this pull request as ready for review April 26, 2023 01:58
@aaron-ai aaron-ai force-pushed the issue_template branch 2 times, most recently from 1f34d13 to 70a301b Compare April 26, 2023 02:03
@aaron-ai
Copy link
Member Author

@RongtongJin I have already added the template of enhancement.

An issue should be considered as an enhancement when it proposes improvements to existing functionality or user experience, without necessarily introducing new features or fixing existing bugs.

By the way, I believe typos should be classified as bugs rather than enhancements; the criteria for an issue to be classified as an enhancement is very strict. Most of issues should be classified as bug or feature request.

@aaron-ai aaron-ai force-pushed the issue_template branch 2 times, most recently from e2b612f to be63901 Compare April 26, 2023 02:18
Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@aaron-ai aaron-ai merged commit b00c82c into apache:develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub issue template improvement plan
4 participants