[ISSUE #6644] Add admin client future interface #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6646 +/- ##
==============================================
+ Coverage 0 42.97% +42.97%
- Complexity 0 8999 +8999
==============================================
Files 0 1109 +1109
Lines 0 78543 +78543
Branches 0 10215 +10215
==============================================
+ Hits 0 33755 +33755
- Misses 0 40560 +40560
- Partials 0 4228 +4228
... and 1106 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superhx
reviewed
Apr 25, 2023
| import org.apache.rocketmq.remoting.protocol.heartbeat.SubscriptionData; | ||
| import org.apache.rocketmq.remoting.protocol.subscription.SubscriptionGroupConfig; | ||
|
|
||
| public class MqClientAdminImpl { |
There was a problem hiding this comment.
For keep admin tools code clean, you could:
- add async interface method in MQAdminExt and move DefaultMQAdminExtImpl async method to DefaultMQAdminExtImpl
- refactor DefaultMQAdminExtImpl blocking method based on async method
There was a problem hiding this comment.
DefaultMQAdminExtImpl is the upper level of MqClientAdminImpl, in fact, the corresponding class to MqClientAdminImpl is MQClientAPIImpl which is almost all sync admin methods.
However, this class is about 3000 lines, and it's too long to add new methods, so I think composition is a good idea.
For interface, It's reasonable to add an interface for this async admin
superhx
reviewed
Apr 25, 2023
remoting/src/main/java/org/apache/rocketmq/remoting/RemotingClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
close #6644
Brief changelog
Add future interface for admin methods