Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6673]Issue template enhancements #6674

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented May 1, 2023

Which Issue(s) This PR Fixes

Fixes #6673

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Merging #6674 (8d8f832) into develop (bcbb25f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6674   +/-   ##
==========================================
  Coverage      43.03%   43.03%           
- Complexity      9018     9021    +3     
==========================================
  Files           1109     1109           
  Lines          78579    78615   +36     
  Branches       10224    10232    +8     
==========================================
+ Hits           33813    33832   +19     
- Misses         40541    40549    +8     
- Partials        4225     4234    +9     

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

description: Describe the RocketMQ version.
options:
- develop
- 5.1.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we need Git commit id rather than the version number?

description: Describe the environment.
options:
- Linux
- Mac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we need to specify the version and branch of the operating system, such as Ubuntu 18.04. Would it be more appropriate to use a textarea here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it needs to be specific to a certain Linux system, using a textarea would be more appropriate. My original idea was just to differentiate between major system types. I will modify it.

@aaron-ai
Copy link
Member

aaron-ai commented May 4, 2023

@mxsm Outstanding job, with a minor suggestion. It looks great overall!

aaron-ai
aaron-ai previously approved these changes May 4, 2023
@mxsm
Copy link
Member Author

mxsm commented May 4, 2023

@aaron-ai I will fix it and resubmit again.

@aaron-ai aaron-ai merged commit 6f6032e into apache:develop May 4, 2023
@mxsm mxsm deleted the rocketmq-6673 branch May 4, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue template enhancements
4 participants