Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6691] Support reentrant pop orderly for broker #6692

Merged
merged 1 commit into from
May 5, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented May 4, 2023

Which Issue(s) This PR Fixes

Fixes #6691

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #6692 (2549542) into develop (d9a7315) will decrease coverage by 0.04%.
The diff coverage is 32.14%.

@@              Coverage Diff              @@
##             develop    #6692      +/-   ##
=============================================
- Coverage      43.07%   43.04%   -0.04%     
- Complexity      8992     9030      +38     
=============================================
  Files           1107     1109       +2     
  Lines          78260    78631     +371     
  Branches       10201    10234      +33     
=============================================
+ Hits           33713    33847     +134     
- Misses         40318    40552     +234     
- Partials        4229     4232       +3     
Impacted Files Coverage Δ
...rocketmq/broker/processor/AckMessageProcessor.java 46.03% <0.00%> (ø)
...cketmq/broker/processor/NotificationProcessor.java 10.65% <0.00%> (ø)
...oting/protocol/header/PopMessageRequestHeader.java 0.00% <0.00%> (ø)
.../apache/rocketmq/test/client/rmq/RMQPopClient.java 0.00% <0.00%> (ø)
...rocketmq/broker/processor/PopMessageProcessor.java 37.16% <16.66%> (-0.46%) ⬇️
...cketmq/broker/offset/ConsumerOrderInfoManager.java 74.91% <57.14%> (-1.25%) ⬇️

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 57642bc into apache:develop May 5, 2023
@xdkxlk xdkxlk deleted the develop-fifo-pop-reentrant branch May 5, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reentrant pop orderly for broker
3 participants