Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6828] return the number of assignments equal to the number of messageQueues for order consumer #6829

Merged
merged 1 commit into from
May 30, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented May 29, 2023

Which Issue(s) This PR Fixes

Fixes #6828

Brief Description

How Did You Test This Change?

Add test cases

@codecov-commenter
Copy link

Codecov Report

Merging #6829 (736cde0) into develop (330d56b) will increase coverage by 0.06%.
The diff coverage is 96.15%.

@@              Coverage Diff              @@
##             develop    #6829      +/-   ##
=============================================
+ Coverage      42.84%   42.90%   +0.06%     
- Complexity      8986     8996      +10     
=============================================
  Files           1105     1105              
  Lines          78472    78489      +17     
  Branches       10227    10230       +3     
=============================================
+ Hits           33619    33674      +55     
+ Misses         40642    40596      -46     
- Partials        4211     4219       +8     
Impacted Files Coverage Δ
...he/rocketmq/proxy/grpc/v2/route/RouteActivity.java 91.12% <96.15%> (+0.33%) ⬆️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@lollipopjin lollipopjin merged commit 40ada80 into apache:develop May 30, 2023
@xdkxlk xdkxlk deleted the develop-6828 branch May 30, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ordered messages of different message group may affect each other for grpc pushConsumer
3 participants