-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6841] new feature: pop batch ack for pushConsumer #6842
Conversation
LGTM~ |
I noticed that we already had some discussions regarding the nested Pop mode of PushConsumer. I suggest that we refrain from introducing further complexity to PushConsumer until we reach a consensus on this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for more discussions.
There's an issue about whether to remove pushConsumer cause it's not firstly designed for pop. |
I have read the issue about removing the POP from |
Codecov Report
@@ Coverage Diff @@
## develop #6842 +/- ##
=============================================
+ Coverage 42.84% 43.00% +0.15%
- Complexity 8986 9102 +116
=============================================
Files 1105 1114 +9
Lines 78472 79078 +606
Branches 10227 10301 +74
=============================================
+ Hits 33620 34004 +384
- Misses 40636 40828 +192
- Partials 4216 4246 +30
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes
Fixes #6841
Brief Description
Currently, the POP consumer can pull up to 32 messages in batch, but after consuming one message, it needs to immediately ack once without achieving batching, which is inefficient and consumes bandwidth and CPU resources for both consumers and brokers.
To address this issue, we propose a solution of POP batch ack.
See the issue #6841 for more details.
How Did You Test This Change?