Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removeOne method for ReceiptHandleGroup #6955

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Jun 27, 2023

Which Issue(s) This PR Fixes

Fixes #6956

Brief Description

How Did You Test This Change?

@xdkxlk xdkxlk marked this pull request as draft June 27, 2023 11:27
@codecov-commenter
Copy link

Codecov Report

Merging #6955 (f91366b) into develop (8ab99ac) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             develop    #6955      +/-   ##
=============================================
- Coverage      42.65%   42.61%   -0.04%     
+ Complexity      9211     9204       -7     
=============================================
  Files           1131     1131              
  Lines          80470    80485      +15     
  Branches       10517    10520       +3     
=============================================
- Hits           34322    34297      -25     
- Misses         41856    41889      +33     
- Partials        4292     4299       +7     
Impacted Files Coverage Δ
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 63.43% <40.00%> (-2.96%) ⬇️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk marked this pull request as ready for review June 28, 2023 02:23
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 87075c2 into apache:develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add removeOne method for ReceiptHandleGroup
3 participants