Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#ISSUE 7035] Fix correct min offset behavior in tiered storage #7038

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Jul 18, 2023

fix #7035

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #7038 (b1f425e) into develop (440be1e) will increase coverage by 0.05%.
The diff coverage is 67.85%.

@@              Coverage Diff              @@
##             develop    #7038      +/-   ##
=============================================
+ Coverage      42.62%   42.67%   +0.05%     
- Complexity      9230     9253      +23     
=============================================
  Files           1136     1136              
  Lines          80652    80694      +42     
  Branches       10542    10546       +4     
=============================================
+ Hits           34375    34435      +60     
+ Misses         41981    41960      -21     
- Partials        4296     4299       +3     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 45.36% <0.00%> (+0.61%) ⬆️
...che/rocketmq/tieredstore/TieredMessageFetcher.java 59.71% <ø> (ø)
...ieredstore/metrics/TieredStoreMetricsConstant.java 0.00% <ø> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.28% <25.00%> (-0.02%) ⬇️
...ache/rocketmq/tieredstore/file/TieredFlatFile.java 77.74% <63.63%> (+2.41%) ⬆️
...che/rocketmq/tieredstore/file/TieredCommitLog.java 68.75% <71.42%> (+6.58%) ⬆️
...e/rocketmq/tieredstore/file/CompositeFlatFile.java 78.39% <75.00%> (+0.21%) ⬆️
...q/tieredstore/provider/posix/PosixFileSegment.java 67.56% <83.33%> (+6.65%) ⬆️
.../apache/rocketmq/tieredstore/TieredDispatcher.java 46.40% <100.00%> (ø)
...cketmq/tieredstore/file/TieredFlatFileManager.java 50.00% <100.00%> (-0.64%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins marked this pull request as draft July 19, 2023 03:45
@lizhimins lizhimins marked this pull request as ready for review July 19, 2023 08:49
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 2c5808b into apache:develop Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix correct min offset behavior in tiered storage
3 participants