Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7056]fix: avoid close success channel if invokeSync most time cost on get connection for channel #7057

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

absolute8511
Copy link
Contributor

…channel

Change-Id: I29741cf55ac6333bfa30fef755357b78a22b1325

Which Issue(s) This PR Fixes

Fixes #7056

Brief Description

How Did You Test This Change?

…channel

Change-Id: I29741cf55ac6333bfa30fef755357b78a22b1325
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@absolute8511 CI not pass, please fix it

Change-Id: I8c9b86e9cb6f1463bf213e64c9b8c139afa794c8
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.77%. Comparing base (804f2d8) to head (e05b76e).
Report is 441 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7057      +/-   ##
=============================================
+ Coverage      42.68%   42.77%   +0.09%     
- Complexity      9254     9285      +31     
=============================================
  Files           1136     1137       +1     
  Lines          80700    81095     +395     
  Branches       10546    10608      +62     
=============================================
+ Hits           34445    34688     +243     
- Misses         41961    42071     +110     
- Partials        4294     4336      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit d797377 into apache:develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] one unreachable nameserver may cause all invokeSync failed forever if there are 2 nameserver in cluster
5 participants