Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7052] Ensuring consistency between broker and nameserver data when deleting a topic #7066

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7052

Brief Description

Ensuring consistency between broker and nameserver data when deleting a topic

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7066 (dfc469a) into develop (804f2d8) will increase coverage by 0.11%.
The diff coverage is 20.37%.

@@              Coverage Diff              @@
##             develop    #7066      +/-   ##
=============================================
+ Coverage      42.68%   42.79%   +0.11%     
- Complexity      9254     9304      +50     
=============================================
  Files           1136     1138       +2     
  Lines          80700    81245     +545     
  Branches       10546    10634      +88     
=============================================
+ Hits           34445    34772     +327     
- Misses         41961    42132     +171     
- Partials        4294     4341      +47     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 47.05% <0.00%> (+3.07%) ⬆️
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 15.69% <0.00%> (-0.97%) ⬇️
...ache/rocketmq/broker/topic/TopicConfigManager.java 55.65% <0.00%> (-0.34%) ⬇️
.../apache/rocketmq/common/namesrv/NamesrvConfig.java 0.00% <0.00%> (ø)
...rg/apache/rocketmq/test/util/MQAdminTestUtils.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 24.14% <25.00%> (-0.03%) ⬇️
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.27% <25.00%> (-0.02%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 65.06% <60.60%> (+1.78%) ⬆️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin changed the title [ISSUE #7052]Ensuring consistency between broker and nameserver data when deleting a topic [ISSUE #7052] Ensuring consistency between broker and nameserver data when deleting a topic Jul 23, 2023
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 047ef74 into apache:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ensuring consistency between broker and nameserver data when deleting a topic
6 participants