[ISSUE #7115] Fix the response message NPE #7116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
approved these changes
Aug 4, 2023
xdkxlk
approved these changes
Aug 4, 2023
RongtongJin
approved these changes
Aug 6, 2023
ferrirW
approved these changes
Aug 7, 2023
mxsm
approved these changes
Aug 7, 2023
lizhimins
changed the title
lizhimins
changed the title
|
@dingshuangxi888 Plz merge the latest development branch to pass ci |
Codecov Report
@@ Coverage Diff @@
## develop #7116 +/- ##
==========================================
Coverage 42.13% 42.14%
+ Complexity 9258 9257 -1
==========================================
Files 1149 1149
Lines 82000 82000
Branches 10694 10695 +1
==========================================
+ Hits 34550 34558 +8
+ Misses 43100 43091 -9
- Partials 4350 4351 +1
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7115
Brief Description
When a system exception occurs in gRPC, such as a NullPointerException (NPE), the Response returned to the client may have its message set to null, resulting in another NPE. In such cases, the client cannot receive the response.
How Did You Test This Change?