-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7131] Replace java.nio.ByteBuffer with class name #7132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, there ci failures, please checkout :)
Hi, I've read the log but can't understand why it building fail, cause I havn't modify any code actually. @joeCarf @RongtongJin |
@RongtongJin Pay attention to this patch, can it be merged? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7132 +/- ##
=============================================
- Coverage 43.20% 43.17% -0.03%
- Complexity 9796 9799 +3
=============================================
Files 1164 1164
Lines 84420 84428 +8
Branches 10961 10963 +2
=============================================
- Hits 36474 36456 -18
- Misses 43420 43447 +27
+ Partials 4526 4525 -1 ☔ View full report in Codecov by Sentry. |
Fixes #7131
Brief Description
How Did You Test This Change?