Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7131] Replace java.nio.ByteBuffer with class name #7132

Closed
wants to merge 0 commits into from

Conversation

zhiliatom
Copy link
Contributor

Fixes #7131

Brief Description

How Did You Test This Change?

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin
Copy link
Contributor

LGTM

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, there ci failures, please checkout :)

@zhiliatom
Copy link
Contributor Author

zhiliatom commented Aug 25, 2023

Hi, I've read the log but can't understand why it building fail, cause I havn't modify any code actually. @joeCarf @RongtongJin

@zhiliatom
Copy link
Contributor Author

@RongtongJin Pay attention to this patch, can it be merged?

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c2c29c2) 43.20% compared to head (5a3cddd) 43.17%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 20.00% 4 Missing ⚠️
...apache/rocketmq/broker/slave/SlaveSynchronize.java 0.00% 3 Missing ⚠️
...pache/rocketmq/common/message/MessageAccessor.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7132      +/-   ##
=============================================
- Coverage      43.20%   43.17%   -0.03%     
- Complexity      9796     9799       +3     
=============================================
  Files           1164     1164              
  Lines          84420    84428       +8     
  Branches       10961    10963       +2     
=============================================
- Hits           36474    36456      -18     
- Misses         43420    43447      +27     
+ Partials        4526     4525       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Replace java.nio.ByteBuffer with class name
6 participants