[ISSUE #7208] fix: when deleting topic also delete its pop retry topic #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdkxlk
reviewed
Aug 18, 2023
common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java
Outdated
Show resolved
Hide resolved
HScarb
force-pushed
the
fix-delete-pop-retry-topic
branch
from
c2da149
to
2732865
Compare
joeCarf
reviewed
Aug 21, 2023
HScarb
force-pushed
the
fix-delete-pop-retry-topic
branch
from
2732865
to
7f28105
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7209 +/- ##
=============================================
+ Coverage 42.43% 42.61% +0.17%
- Complexity 9343 9412 +69
=============================================
Files 1149 1152 +3
Lines 82059 82344 +285
Branches 10699 10725 +26
=============================================
+ Hits 34825 35094 +269
- Misses 42862 42873 +11
- Partials 4372 4377 +5
... and 58 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
humkum
approved these changes
Aug 21, 2023
xdkxlk
reviewed
Aug 22, 2023
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
Show resolved
Hide resolved
HScarb
force-pushed
the
fix-delete-pop-retry-topic
branch
from
7f28105
to
093351c
Compare
joeCarf
reviewed
Aug 23, 2023
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
Outdated
Show resolved
Hide resolved
HScarb
force-pushed
the
fix-delete-pop-retry-topic
branch
from
093351c
to
a4819a6
Compare
yuz10
approved these changes
Aug 31, 2023
HScarb
added a commit
to HScarb/rocketmq
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7208
Brief Description
when deleting topic, search for its pop retry topic and delete them
How Did You Test This Change?
unit test was added