[ISSUE #7326] Split the request to register to the nameserver #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziy1-Tan
changed the title
Ziy1-Tan
changed the title
Ziy1-Tan
force-pushed
the
develop
branch
2 times, most recently
from
8b3ead0
to
289b16b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7325 +/- ##
=============================================
- Coverage 42.69% 42.64% -0.05%
+ Complexity 9474 9466 -8
=============================================
Files 1152 1152
Lines 82721 82746 +25
Branches 10781 10783 +2
=============================================
- Hits 35315 35288 -27
- Misses 42997 43042 +45
- Partials 4409 4416 +7
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fuyou001
reviewed
Sep 8, 2023
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
Outdated
Show resolved
Hide resolved
Ziy1-Tan
force-pushed
the
develop
branch
7 times, most recently
from
6882f04
to
4c3f678
Compare
RongtongJin
reviewed
Sep 9, 2023
| topicConfigWrapper.setTopicConfigTable(this.getTopicConfigManager().getTopicConfigTable()); | ||
| if (this.brokerConfig.isEnableSplitRegistration() | ||
| && topicConfigTable.size() >= this.brokerConfig.getSplitRegistrationSize() | ||
| && needRegister(forceRegister)) { |
There was a problem hiding this comment.
There is no need to determine needRegister here
Comment on lines
1811
to
1815
| private TopicConfigAndMappingSerializeWrapper buildSerializeWrapper(final ConcurrentMap<String, TopicConfig> topicConfigTable) { | ||
| return buildSerializeWrapper(topicConfigTable, Maps.newHashMap()); | ||
| } | ||
|
|
||
| private TopicConfigAndMappingSerializeWrapper buildSerializeWrapper( |
There was a problem hiding this comment.
It would be better move these two methods to TopicConfigManager
| @@ -396,6 +396,10 @@ public class BrokerConfig extends BrokerIdentity { | |||
|
|
|||
| private boolean enableMixedMessageType = false; | |||
|
|
|||
| private boolean enableSplitRegistration = false; | |||
There was a problem hiding this comment.
Just a reminder to the users that this switch cannot be used together with deleteTopicWithBrokerRegistration, otherwise there will be a loss of routing.
RongtongJin
previously approved these changes
Sep 10, 2023
Signed-off-by: Ziy1-Tan <[email protected]>
RongtongJin
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7326
Brief Description
How Did You Test This Change?