Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #7334] registerIncrementBrokerData for single topic update #7335

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[ISSUE #7334] registerIncrementBrokerData for single topic update #7335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ public TopicConfig createTopicInSendMessageMethod(final String topic, final Stri
}

if (createNew) {
this.brokerController.registerBrokerAll(false, true, true);
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
this.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dataVersion);
}
}

return topicConfig;
Expand Down Expand Up @@ -394,7 +398,11 @@ public TopicConfig createTopicInSendMessageBackMethod(
}

if (createNew) {
this.brokerController.registerBrokerAll(false, true, true);
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
this.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dataVersion);
}
}

return topicConfig;
Expand Down Expand Up @@ -435,7 +443,11 @@ public TopicConfig createTopicOfTranCheckMaxTime(final int clientDefaultTopicQue
}

if (createNew) {
this.brokerController.registerBrokerAll(false, true, true);
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
this.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dataVersion);
}
}

return topicConfig;
Expand All @@ -461,7 +473,11 @@ public void updateTopicUnitFlag(final String topic, final boolean unit) {
dataVersion.nextVersion(stateMachineVersion);

this.persist();
this.brokerController.registerBrokerAll(false, true, true);
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
this.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dataVersion);
}
}
}

Expand All @@ -484,7 +500,11 @@ public void updateTopicUnitSubFlag(final String topic, final boolean hasUnitSub)
dataVersion.nextVersion(stateMachineVersion);

this.persist();
this.brokerController.registerBrokerAll(false, true, true);
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
this.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dataVersion);
}
}
}

Expand Down
Loading