[ISSUE #7345] Fix wrong result of searchOffset in tiered storage #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7346 +/- ##
=============================================
- Coverage 42.65% 42.61% -0.05%
+ Complexity 9473 9456 -17
=============================================
Files 1150 1150
Lines 82754 82756 +2
Branches 10789 10790 +1
=============================================
- Hits 35300 35265 -35
- Misses 43043 43074 +31
- Partials 4411 4417 +6
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhimins
reviewed
Sep 12, 2023
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/TieredFlatFile.java
Show resolved
Hide resolved
lizhimins
approved these changes
Sep 12, 2023
joeCarf
reviewed
Sep 12, 2023
| return fileSegmentList.isEmpty() ? null : fileSegmentList.get(fileSegmentList.size() - 1); | ||
| if (fileSegmentList.isEmpty()) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
fileSegmentList并非排序过滤后的，segmentList才是
There was a problem hiding this comment.
这里应该是排序好了的，segmentList为空才走到这里
There was a problem hiding this comment.
在这个上下文中我没有看到fileSegmentList排序的依据，辛苦贴一下相关代码位置
lizhimins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7345
Brief Description
How Did You Test This Change?