Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7363] Fix get message from tiered storage return incorrect next begin offset #7365

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

lizhimins
Copy link
Member

…xt pull offset

Which Issue(s) This PR Fixes

Fixes #7363

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7365 (6a08f1f) into develop (4a8e0d5) will decrease coverage by 0.14%.
The diff coverage is 71.42%.

@@              Coverage Diff              @@
##             develop    #7365      +/-   ##
=============================================
- Coverage      42.68%   42.54%   -0.14%     
+ Complexity      9482     9443      -39     
=============================================
  Files           1150     1150              
  Lines          82729    82727       -2     
  Branches       10777    10775       -2     
=============================================
- Hits           35311    35195     -116     
- Misses         43012    43125     +113     
- Partials        4406     4407       +1     
Files Changed Coverage Δ
...pache/rocketmq/tieredstore/TieredMessageStore.java 70.42% <66.66%> (-3.07%) ⬇️
...che/rocketmq/tieredstore/TieredMessageFetcher.java 59.20% <100.00%> (ø)

... and 45 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 831fcc7 into apache:develop Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Get message from tiered storage return incorrect next begin offset
5 participants