Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7462] Remove deprecated LocalTransactionExecuter #7463

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

985492783
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7462

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7463 (78e3521) into develop (2113fa3) will increase coverage by 0.27%.
Report is 1 commits behind head on develop.
The diff coverage is 59.18%.

@@              Coverage Diff              @@
##             develop    #7463      +/-   ##
=============================================
+ Coverage      42.68%   42.95%   +0.27%     
- Complexity      9481     9658     +177     
=============================================
  Files           1150     1161      +11     
  Lines          82828    83915    +1087     
  Branches       10772    10898     +126     
=============================================
+ Hits           35352    36047     +695     
- Misses         43050    43385     +335     
- Partials        4426     4483      +57     
Files Coverage Δ
...he/rocketmq/broker/controller/ReplicasManager.java 45.84% <ø> (ø)
...mq/broker/offset/RocksDBConsumerOffsetManager.java 83.78% <100.00%> (ø)
...rocketmq/broker/processor/AckMessageProcessor.java 71.51% <100.00%> (ø)
...broker/processor/ChangeInvisibleTimeProcessor.java 56.81% <100.00%> (ø)
...cketmq/broker/topic/RocksDBTopicConfigManager.java 78.12% <100.00%> (ø)
...he/rocketmq/client/producer/DefaultMQProducer.java 54.34% <ø> (+0.17%) ⬆️
...ocketmq/client/producer/TransactionMQProducer.java 55.81% <ø> (+4.75%) ⬆️
...c/main/java/org/apache/rocketmq/common/MixAll.java 38.98% <ø> (ø)
...e/rocketmq/common/config/ConfigRocksDBStorage.java 0.00% <ø> (ø)
...g/apache/rocketmq/common/topic/TopicValidator.java 96.61% <100.00%> (+0.05%) ⬆️
... and 39 more

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title [ISSUE #7462] remove deprecated LocalTransactionExecuter.java [ISSUE #7462] Remove deprecated LocalTransactionExecuter Nov 21, 2023
@lizhimins lizhimins merged commit ca721b0 into apache:develop Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] remove Deprecated class
4 participants