Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7330] Fix channel connect issue for goaway #7467

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Oct 16, 2023

  • add waitChannelFuture for goaway

  • add body for retry channel

Which Issue(s) This PR Fixes

Fixes #7330

Brief Description

Fix channel connect issue for goaway

How Did You Test This Change?

exist unit test

* add waitChannelFuture for goaway

* add body for retry channel
@codecov-commenter
Copy link

Codecov Report

Merging #7467 (976e286) into develop (0f01df4) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 28.57%.

@@              Coverage Diff              @@
##             develop    #7467      +/-   ##
=============================================
- Coverage      42.97%   42.95%   -0.02%     
+ Complexity      9665     9660       -5     
=============================================
  Files           1161     1161              
  Lines          83920    83926       +6     
  Branches       10898    10899       +1     
=============================================
- Hits           36064    36054      -10     
- Misses         43379    43394      +15     
- Partials        4477     4478       +1     
Files Coverage Δ
...he/rocketmq/broker/processor/PopReviveService.java 36.38% <25.00%> (ø)
...e/rocketmq/remoting/netty/NettyRemotingClient.java 40.29% <31.25%> (-0.24%) ⬇️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drpmma drpmma merged commit d73b601 into apache:develop Oct 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [ISSUE #7296] [TASK 3] Add goaway and reconnection mechanism
3 participants