Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7545] Fix set mapped file to null cause file can not destroy #7612

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #7545, Fix set mapped file to null cause file can not destroy in tiered storage index

Brief Description

How Did You Test This Change?

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (65faea2) 43.19% compared to head (c9c80a5) 43.22%.

Files Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7612      +/-   ##
=============================================
+ Coverage      43.19%   43.22%   +0.02%     
- Complexity      9782     9792      +10     
=============================================
  Files           1162     1162              
  Lines          84378    84382       +4     
  Branches       10955    10956       +1     
=============================================
+ Hits           36451    36477      +26     
+ Misses         43397    43374      -23     
- Partials        4530     4531       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lizhimins lizhimins merged commit c2c29c2 into apache:develop Dec 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RIP-65] Support efficient random index for massive messages
4 participants