Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7642] Add return value for sendHeartbeat related method #7643

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Dec 12, 2023

Add sendHeartbeatToBroker

Which Issue(s) This PR Fixes

Fixes #7642

Brief Description

Add return value for sendHeartbeat related method

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (c2c29c2) 43.20% compared to head (87c733a) 43.17%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...rocketmq/client/impl/factory/MQClientInstance.java 4.54% 84 Missing ⚠️
...apache/rocketmq/store/timer/TimerMessageStore.java 20.00% 4 Missing ⚠️
...apache/rocketmq/broker/slave/SlaveSynchronize.java 0.00% 3 Missing ⚠️
...pache/rocketmq/common/message/MessageAccessor.java 0.00% 3 Missing ⚠️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7643      +/-   ##
=============================================
- Coverage      43.20%   43.17%   -0.03%     
- Complexity      9796     9806      +10     
=============================================
  Files           1164     1164              
  Lines          84420    84456      +36     
  Branches       10961    10967       +6     
=============================================
- Hits           36474    36465       -9     
- Misses         43420    43476      +56     
+ Partials        4526     4515      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma self-assigned this Dec 21, 2023
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 620e6a2 into apache:develop Dec 27, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add return value for sendHeartbeat related method
5 participants