Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7821] Add notifyLast flag for PopLongPollingService #7835

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Feb 19, 2024

Which Issue(s) This PR Fixes

Fixes #7821

Brief Description

Add notifyLast flag for PopLongPollingService

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d9526e7) 43.00% compared to head (01feb54) 42.95%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...etmq/broker/longpolling/PopLongPollingService.java 18.18% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7835      +/-   ##
=============================================
- Coverage      43.00%   42.95%   -0.06%     
+ Complexity      9919     9907      -12     
=============================================
  Files           1190     1190              
  Lines          85948    85988      +40     
  Branches       11074    11080       +6     
=============================================
- Hits           36964    36932      -32     
- Misses         44411    44479      +68     
- Partials        4573     4577       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 6f37957 into apache:develop Feb 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add notifyLast for PopLongPollingService
3 participants