Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7970]remove unnecessary type cast #7971

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ChineseTony
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7970

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.83%. Comparing base (59220d8) to head (223de46).

Files Patch % Lines
...ting/protocol/header/SendMessageRequestHeader.java 0.00% 2 Missing ⚠️
...che/rocketmq/remoting/netty/NettyServerConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7971      +/-   ##
=============================================
- Coverage      42.85%   42.83%   -0.02%     
+ Complexity     10353    10344       -9     
=============================================
  Files           1270     1270              
  Lines          88619    88617       -2     
  Branches       11395    11395              
=============================================
- Hits           37975    37958      -17     
- Misses         45962    45968       +6     
- Partials        4682     4691       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChineseTony
Copy link
Contributor Author

hello @RongtongJin @lizhimins request.decodeCommandCustomHeader have generic type, Is it necessary remove all redundancy code for type case?

@caigy caigy merged commit d2818da into apache:develop Mar 28, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove Unnecessary cast type
6 participants