Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#8142] Show time of create topic and subScriptionGroup #8143

Merged
merged 3 commits into from
May 20, 2024
Merged

[ISSUE#8142] Show time of create topic and subScriptionGroup #8143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63b02ea
show time of create topic and subScriptionGroup
May 15, 2024
3b97617
show time of create topic and subScriptionGroup again
superdev42 May 15, 2024
06bb759
show time of create topic and subScriptionGroup changed
superdev42 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ public boolean rejectRequest() {

private synchronized RemotingCommand updateAndCreateTopic(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
long startTime = System.currentTimeMillis();
final RemotingCommand response = RemotingCommand.createResponseCommand(null);
final CreateTopicRequestHeader requestHeader =
(CreateTopicRequestHeader) request.decodeCommandCustomHeader(CreateTopicRequestHeader.class);
Expand Down Expand Up @@ -514,8 +515,10 @@ private synchronized RemotingCommand updateAndCreateTopic(ChannelHandlerContext
LOGGER.error("Update / create topic failed for [{}]", request, e);
response.setCode(ResponseCode.SYSTEM_ERROR);
response.setRemark(e.getMessage());
return response;
}

long executionTime = System.currentTimeMillis() - startTime;
LOGGER.info("executionTime of create topic:{} is {} ms" , topic, executionTime);
return response;
}

Expand Down Expand Up @@ -1450,6 +1453,7 @@ public void onException(Throwable e) {

private RemotingCommand updateAndCreateSubscriptionGroup(ChannelHandlerContext ctx, RemotingCommand request)
throws RemotingCommandException {
long startTime = System.currentTimeMillis();
final RemotingCommand response = RemotingCommand.createResponseCommand(null);

LOGGER.info("AdminBrokerProcessor#updateAndCreateSubscriptionGroup called by {}",
Expand All @@ -1462,6 +1466,8 @@ private RemotingCommand updateAndCreateSubscriptionGroup(ChannelHandlerContext c

response.setCode(ResponseCode.SUCCESS);
response.setRemark(null);
long executionTime = System.currentTimeMillis() - startTime;
LOGGER.info("executionTime of create subscriptionGroup:{} is {} ms" ,config.getGroupName() ,executionTime);
return response;
}

Expand Down Expand Up @@ -3154,7 +3160,7 @@ private boolean validateSlave(RemotingCommand response) {
}

private boolean validateBlackListConfigExist(Properties properties) {
for (String blackConfig:configBlackList) {
for (String blackConfig : configBlackList) {
if (properties.containsKey(blackConfig)) {
return true;
}
Expand Down
Loading