Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8332] fix: ack msg which has reached maxReconsumeTimes #8333

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Jun 26, 2024

Which Issue(s) This PR Fixes

Fixes #8332

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.15%. Comparing base (a89ebe3) to head (335312b).

Files Patch % Lines
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 0.00% 9 Missing ⚠️
...consumer/ConsumeMessagePopConcurrentlyService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8333      +/-   ##
=============================================
- Coverage      43.20%   43.15%   -0.05%     
+ Complexity     10525    10515      -10     
=============================================
  Files           1274     1274              
  Lines          88940    88947       +7     
  Branches       11434    11436       +2     
=============================================
- Hits           38428    38389      -39     
- Misses         45801    45836      +35     
- Partials        4711     4722      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit ce27e1f into apache:develop Jul 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Msg will be consumed even if it has reached max reconsumeTimes in some case
4 participants